contrib: use ENV flags in get_arch #30074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we fail to link when trying to use lld.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
|
Guix Build (aarch64): fcb75f2a3b61befeabe143301e5db490d23b1ee4a5edb109f219dea575395b49 guix-build-b59a027d957a/output/aarch64-linux-gnu/SHA256SUMS.part
15310e3aff2a9ef71bad06315fcd425e56611d5bed7f6c394f3fe2248140e17b guix-build-b59a027d957a/output/aarch64-linux-gnu/bitcoin-b59a027d957a-aarch64-linux-gnu-debug.tar.gz
8e60146d39a47e9c332e3b842e239f1ca7773ca2e6788876155377f4568ab1fa guix-build-b59a027d957a/output/aarch64-linux-gnu/bitcoin-b59a027d957a-aarch64-linux-gnu.tar.gz
10432256ead82aa9f6c6434eab427b2da70d7c17353274abd09dbde74380bfcc guix-build-b59a027d957a/output/arm-linux-gnueabihf/SHA256SUMS.part
96c131400a038434f5338926d72c62d7fa260daf3dde9966c7d7880a182b0b6e guix-build-b59a027d957a/output/arm-linux-gnueabihf/bitcoin-b59a027d957a-arm-linux-gnueabihf-debug.tar.gz
52a3e2e864dd715480bebfc1ab6e72424270145d4e3994d656d13a7f1768f2ef guix-build-b59a027d957a/output/arm-linux-gnueabihf/bitcoin-b59a027d957a-arm-linux-gnueabihf.tar.gz
5104daf56a644a946157998f18c01d1c014d11e88c142f60490fe821b4e23d22 guix-build-b59a027d957a/output/arm64-apple-darwin/SHA256SUMS.part
23bd453e64b4883ffaf479ddd5f87a6beb69aa54ede8e766736675913ff12aac guix-build-b59a027d957a/output/arm64-apple-darwin/bitcoin-b59a027d957a-arm64-apple-darwin-unsigned.tar.gz
a5bb4d0d5b11036a7cfacd67b61a2617c282e320881e176f6c4d8e323ba90b9c guix-build-b59a027d957a/output/arm64-apple-darwin/bitcoin-b59a027d957a-arm64-apple-darwin-unsigned.zip
3e0b68e6da97b0f735d5dec45ab6e05fb498cd7dbc2de02739d04ae0713f54c7 guix-build-b59a027d957a/output/arm64-apple-darwin/bitcoin-b59a027d957a-arm64-apple-darwin.tar.gz
0bacff86ef3e47e32ac141f1b496c0f55c1e846da4768c2a9fa5648ed397eb61 guix-build-b59a027d957a/output/dist-archive/bitcoin-b59a027d957a.tar.gz
0d0db2d1b7ad72596a3916ed141d2a43d53487bcd34b958a4bbdeef5d4f5fea1 guix-build-b59a027d957a/output/powerpc64-linux-gnu/SHA256SUMS.part
b40f62ca796c607a48aed528de19a4406b49130ddffee95061e17ba2d620384c guix-build-b59a027d957a/output/powerpc64-linux-gnu/bitcoin-b59a027d957a-powerpc64-linux-gnu-debug.tar.gz
187b3f1dd9585d91aa8a5185aa86dde8a743f34787e710b9a5c755c03b755a67 guix-build-b59a027d957a/output/powerpc64-linux-gnu/bitcoin-b59a027d957a-powerpc64-linux-gnu.tar.gz
d37b86e2b6f4c66bc76d9e73b9bbd9a33f5a83bbf048719e4564dd9b147c2b85 guix-build-b59a027d957a/output/riscv64-linux-gnu/SHA256SUMS.part
989d1a9c3958ffe467de5c6f682944dc939db5c9e8e42ed40dc6ec6710fafe5c guix-build-b59a027d957a/output/riscv64-linux-gnu/bitcoin-b59a027d957a-riscv64-linux-gnu-debug.tar.gz
b23e4b83c0171630dc6c27a3846b5a62f940a9c6f3b24e6e8e2a1537a8fa045c guix-build-b59a027d957a/output/riscv64-linux-gnu/bitcoin-b59a027d957a-riscv64-linux-gnu.tar.gz
fbc95186aef10cf65727eb4296b7d21063d04e3ffda82dc918b6c8cddd01a20b guix-build-b59a027d957a/output/x86_64-apple-darwin/SHA256SUMS.part
06911415068f781e00a52705f3c920a353065448941c43ffcb30495146d1f58a guix-build-b59a027d957a/output/x86_64-apple-darwin/bitcoin-b59a027d957a-x86_64-apple-darwin-unsigned.tar.gz
e0fa356fac020116febef400e0b81850196575801dd749580e8ebce3fecdbacf guix-build-b59a027d957a/output/x86_64-apple-darwin/bitcoin-b59a027d957a-x86_64-apple-darwin-unsigned.zip
b0aae18c633631220a256351c420b1202de68f21f643a51aed208e7f5b06beed guix-build-b59a027d957a/output/x86_64-apple-darwin/bitcoin-b59a027d957a-x86_64-apple-darwin.tar.gz
52d765a9f8254fb5eed3acaf1d2e79e3861959a6cd573f516d5d1e3552302064 guix-build-b59a027d957a/output/x86_64-linux-gnu/SHA256SUMS.part
c6343c951a6818dd790b0cf2eae5f4432d99cc0b95617acb76510a866a0c2ac2 guix-build-b59a027d957a/output/x86_64-linux-gnu/bitcoin-b59a027d957a-x86_64-linux-gnu-debug.tar.gz
d02725d7ccd074031cda251e16bd4dac1743c07c5cb309920e6f080e3d88bc26 guix-build-b59a027d957a/output/x86_64-linux-gnu/bitcoin-b59a027d957a-x86_64-linux-gnu.tar.gz
5b4dc2d2514baea62ccd2b7104db919280d60ff0ffd7778dba9738fce308cd6c guix-build-b59a027d957a/output/x86_64-w64-mingw32/SHA256SUMS.part
ed655ebd40ebdec1c4dd5a2ec88496adb8b5ae53a5b6ef4a86b39dcc2dc69c6b guix-build-b59a027d957a/output/x86_64-w64-mingw32/bitcoin-b59a027d957a-win64-debug.zip
5b8e8ca1b8351b9656def4e76bc90a61d9a78a5b9f03d01a46bda7724d1e75b1 guix-build-b59a027d957a/output/x86_64-w64-mingw32/bitcoin-b59a027d957a-win64-setup-unsigned.exe
92e0678d69747a5d59e4856766088bfd89b712e8177f32bdaa6ea8b3711941af guix-build-b59a027d957a/output/x86_64-w64-mingw32/bitcoin-b59a027d957a-win64-unsigned.tar.gz
adff1f20e85082280a1fa55595bbf83c4d4d31cfd72742b3c4b88617a033a22f guix-build-b59a027d957a/output/x86_64-w64-mingw32/bitcoin-b59a027d957a-win64.zip |
|
The second commit b59a027 seems trivially correct since I got a bit confused about its history, so here it is:
I'll do a guix build... |
|
Guix build (aarch64): |
willcl-ark
reviewed
May 15, 2024
There was a problem hiding this comment.
post-merge ACK b59a027
My hashes match, but don't include the output/*/SHA256SUMS.part output lines:
15310e3aff2a9ef71bad06315fcd425e56611d5bed7f6c394f3fe2248140e17b bitcoin-b59a027d957a-aarch64-linux-gnu-debug.tar.gz
8e60146d39a47e9c332e3b842e239f1ca7773ca2e6788876155377f4568ab1fa bitcoin-b59a027d957a-aarch64-linux-gnu.tar.gz
96c131400a038434f5338926d72c62d7fa260daf3dde9966c7d7880a182b0b6e bitcoin-b59a027d957a-arm-linux-gnueabihf-debug.tar.gz
52a3e2e864dd715480bebfc1ab6e72424270145d4e3994d656d13a7f1768f2ef bitcoin-b59a027d957a-arm-linux-gnueabihf.tar.gz
23bd453e64b4883ffaf479ddd5f87a6beb69aa54ede8e766736675913ff12aac bitcoin-b59a027d957a-arm64-apple-darwin-unsigned.tar.gz
a5bb4d0d5b11036a7cfacd67b61a2617c282e320881e176f6c4d8e323ba90b9c bitcoin-b59a027d957a-arm64-apple-darwin-unsigned.zip
3e0b68e6da97b0f735d5dec45ab6e05fb498cd7dbc2de02739d04ae0713f54c7 bitcoin-b59a027d957a-arm64-apple-darwin.tar.gz
0bacff86ef3e47e32ac141f1b496c0f55c1e846da4768c2a9fa5648ed397eb61 bitcoin-b59a027d957a.tar.gz
b40f62ca796c607a48aed528de19a4406b49130ddffee95061e17ba2d620384c bitcoin-b59a027d957a-powerpc64-linux-gnu-debug.tar.gz
187b3f1dd9585d91aa8a5185aa86dde8a743f34787e710b9a5c755c03b755a67 bitcoin-b59a027d957a-powerpc64-linux-gnu.tar.gz
989d1a9c3958ffe467de5c6f682944dc939db5c9e8e42ed40dc6ec6710fafe5c bitcoin-b59a027d957a-riscv64-linux-gnu-debug.tar.gz
b23e4b83c0171630dc6c27a3846b5a62f940a9c6f3b24e6e8e2a1537a8fa045c bitcoin-b59a027d957a-riscv64-linux-gnu.tar.gz
06911415068f781e00a52705f3c920a353065448941c43ffcb30495146d1f58a bitcoin-b59a027d957a-x86_64-apple-darwin-unsigned.tar.gz
e0fa356fac020116febef400e0b81850196575801dd749580e8ebce3fecdbacf bitcoin-b59a027d957a-x86_64-apple-darwin-unsigned.zip
b0aae18c633631220a256351c420b1202de68f21f643a51aed208e7f5b06beed bitcoin-b59a027d957a-x86_64-apple-darwin.tar.gz
c6343c951a6818dd790b0cf2eae5f4432d99cc0b95617acb76510a866a0c2ac2 bitcoin-b59a027d957a-x86_64-linux-gnu-debug.tar.gz
d02725d7ccd074031cda251e16bd4dac1743c07c5cb309920e6f080e3d88bc26 bitcoin-b59a027d957a-x86_64-linux-gnu.tar.gz
ed655ebd40ebdec1c4dd5a2ec88496adb8b5ae53a5b6ef4a86b39dcc2dc69c6b bitcoin-b59a027d957a-win64-debug.zip
5b8e8ca1b8351b9656def4e76bc90a61d9a78a5b9f03d01a46bda7724d1e75b1 bitcoin-b59a027d957a-win64-setup-unsigned.exe
92e0678d69747a5d59e4856766088bfd89b712e8177f32bdaa6ea8b3711941af bitcoin-b59a027d957a-win64-unsigned.tar.gz
adff1f20e85082280a1fa55595bbf83c4d4d31cfd72742b3c4b88617a033a22f bitcoin-b59a027d957a-win64.zip
fanquake
added a commit
that referenced
this pull request
May 22, 2024
fa3e115 doc: Correct pull request prefix for scripts and tools (MarcoFalke) Pull request description: `script` is confusing, because in the context of Bitcoin, it usually means Bitcoin script (c.f. `CScript` in `script.h`, or pull requests such as #27122 using the prefix). This could be fixed by renaming it to `scripts` (with a plural `s` at the end), however, looking at the current usage `contrib` and `cli` seem more common (#29687, #26953, #26584, #24864, #30074, #29433 ...) ACKs for top commit: fanquake: ACK fa3e115 willcl-ark: ACK fa3e115 hebasto: ACK fa3e115. theuni: ACK fa3e115 Tree-SHA512: fb3a3892ca5f859e590c8a620350c397ef1f9eafd9e174c70ef50095d401a396758d6c93ad41888da8025c41e25e691f30c18f9e974af13597f2266bb2c53b6d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't an issue right now (because the get_arch check is simple), but becomes one as soon as we want to use
lldfor linking, and need LDFLAGS (otherwise we callldand fail, see it's usage in #21778). So I've split this out for review. It also makes sense to use the same flags for all compilation in these checks.Also drops some dead code in test-symbol-check.