net: log connections failures via SOCKS5 with less severity #30064
Conversation
It is expected to have some Bitcoin nodes unreachable some of the time. A failure to connect to an IPv4 or IPv6 node is already properly logged under category=net/severity=debug. Do the same when a connection fails when using a SOCKS5 proxy. This could be either to an .onion address or to an IPv4 or IPv6 address (via a Tor exit node). Related: bitcoin#29759
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsNo conflicts as of last run. |
There was a problem hiding this comment.
Concept ACK, a0be62c (#25203) contains these changes and further ones, perhaps look if other ones there could be done here.
| @@ -544,9 +545,9 @@ template<typename... Args> | |||
| static void LogConnectFailure(bool manual_connection, const char* fmt, const Args&... args) { | |||
| std::string error_message = tfm::format(fmt, args...); | |||
| if (manual_connection) { | |||
| LogPrintf("%s\n", error_message); | |||
| LogPrintLevel(BCLog::NET, BCLog::Level::Info, "%s\n", error_message); | |||
There was a problem hiding this comment.
In this case, I had added Manual and considered it an error (or perhaps warning), what do you think: a0be62c#diff-3499e52d708f04ebd0bfeec799dd26464ca6bd26a802c700460227c4f41ec4b5R541
| LogPrintLevel(BCLog::NET, BCLog::Level::Info, "%s\n", error_message); | |
| LogPrintLevel(BCLog::NET, BCLog::Level::Error, "Manual %s\n", error_message); |
It is expected to have some Bitcoin nodes unreachable some of the time. A failure to connect to an IPv4 or IPv6 node is already properly logged under category=net/severity=debug. Do the same when a connection fails when using a SOCKS5 proxy. This could be either to an .onion address or to an IPv4 or IPv6 address (via a Tor exit node).
Related: #29759