Fix ruby 1.9.3 warnings #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n.rb. Unused variables commented out are medline, aaindex, litdb, fantom, clustal, gcg_msf, gcg_seq, blastxml, rpsblast, blat, spidey, hmmer, sim4.
|
The 3 changes to defline.rb and alignment.rb are included. |
|
I don't like 1a2d1de because the variables will be used in the future code. |
|
The variable names are still there, but commented out. Alternatively, an underscore |
|
my 2 pence if there's code that isn't being used, it should be removed. It's easy enough to keep a separate feature branch for things like this to be merged in when they're ready to be used. Regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix warnings made by Ruby 1.9.2 or 1.9.3.
This is similar to #64, but only some of the changes are included, and the commits have got more verbose comments.