refactor(biome_graphql_parser): remove is_at_*_definition #2841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #2841 will not alter performanceComparing Summary
|
ematipico
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following the fix that add support for using keywords as identifiers in GraphQL, the conditions used to verify the absence of definitions have become simpler. This PR simplifies those checks in to a simple match clause, making it clearer under which condition a definition is parsed.
Additionally, this PR servers as a stepping stone toward parsing extensions in GraphQL.
Test Plan
This PR solely refactors the checks for GraphQL definitions, no tests was modified. All tests should still pass.