fix(biome_service): add magic vue compiler macros to globals for vue single file components #2823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyc3
force-pushed
the
05-12-fix_biome_service_add_magic_vue_compiler_macros_to_globals_for_vue_single_file_components
branch
from
331ece2
to
2a4f943
Compare
ematipico
reviewed
May 13, 2024
dyc3
force-pushed
the
05-12-fix_biome_service_add_magic_vue_compiler_macros_to_globals_for_vue_single_file_components
branch
from
2a4f943
to
cb0b108
Compare
dyc3
force-pushed
the
05-12-fix_biome_service_add_magic_vue_compiler_macros_to_globals_for_vue_single_file_components
branch
2 times, most recently
from
2f7eb26
to
77cafce
Compare
|
|
ematipico
approved these changes
May 16, 2024
There was a problem hiding this comment.
Can you add a changelog line to the changelog? https://github.com/biomejs/biome/blob/main/CONTRIBUTING.md#writing-a-changelog-line
After that, we can merge it!
…single file components
dyc3
force-pushed
the
05-12-fix_biome_service_add_magic_vue_compiler_macros_to_globals_for_vue_single_file_components
branch
from
77cafce
to
23453b2
Compare
|
Not sure if I put it in the right section. |
dyc3
deleted the
05-12-fix_biome_service_add_magic_vue_compiler_macros_to_globals_for_vue_single_file_components
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Vue has some magic compiler macros that are treated like globals when writing single file components. This makes it unnecessary for users to manually configure biome to treat them as globals.
closes #2771
Test Plan
Added a test.