Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend docs on htmx:confirm and its detail.question property. #2550

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JanRomero
Copy link

@JanRomero JanRomero commented May 16, 2024

Hello,

tbh I find the behaviour described in this commit kind of weird and would prefer the event not to fire without hx-confirm, but as that may break some folks’ stuff, I made the docs more clear on what to expect. See also this issue: #2029 or this recent question on SO: https://stackoverflow.com/questions/78479683/htmxconfirm-event-firing-on-every-ajax-call.

Thanks!

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue

@Telroshan Telroshan added the documentation Improvements or additions to documentation label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants