Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version into deno bids-validator.js + create shim to run it #1942

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yarikoptic
Copy link
Contributor

This way anyone interested to use it could just

git clone --depth 1 -b deno-build http://github.com/bids-standard/bids-validator
export PATH="$PWD/bids-validator:$PATH"

and start using it and know which version it is:

❯ bids-validator -V
v1.14.6-dev.0-9-gdc61d0f3.deno

An alternative for shim would be just to create it in that branch and then remove in CI only the .js files. I would be happy to redo if feels more sensible.

This way anyone interested to use it could just

    git clone --depth 1 -b deno-build http://github.com/bids-standard/bids-validator
    export PATH="$PWD/bids-validator:$PATH"

and start using it and know which version it is:

    ❯ bids-validator -V
    v1.14.6-dev.0-9-gdc61d0f3.deno

An alternative for shim would be just to create it in that branch and then
remove in CI only the .js files.  I would be happy to redo if feels more sensible.
@effigies
Copy link
Collaborator

This is fine with me. In general, it would be good to get the version into the builds. Running from deno.land also shows "alpha".

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.58%. Comparing base (bc15afc) to head (c01bc77).
Report is 25 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1942      +/-   ##
==========================================
+ Coverage   85.58%   86.58%   +0.99%     
==========================================
  Files          91      130      +39     
  Lines        3768     5964    +2196     
  Branches     1207     1481     +274     
==========================================
+ Hits         3225     5164    +1939     
- Misses        457      709     +252     
- Partials       86       91       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic
Copy link
Contributor Author

yes - this is a poor man solution. Should remain working even when alpha would be replaced with a correct one! note that I added .deno at the end to tell them apart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants