Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] BEP020 Eyetracking #1423

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[WIP] BEP020 Eyetracking #1423

wants to merge 2 commits into from

Conversation

rwblair
Copy link
Member

@rwblair rwblair commented Mar 2, 2022

Based off google doc.

todo/issues:

  • json schema does not have correct types for any of the object of objects, from the examples I could see some of these may be arrays of arrays of strings.
  • file regex does not include .asc as this was not in the google doc template but should be a valid template
  • regex only allows for file in eyetrack/ this may change to allow eyetracking data appear next to any modality.
  • template and example datasets have session in filename but not as a directory, validator throws and error for this as historically both were required and had to match for a given file name.
  • events tsv validation logic will need to be updated if the above is allowed.
  • events.tsv does not cross reference sidecar and _events.tsv eventIdentifier field to ensure they share the same values.
  • json tests
  • tsv tests
  • filename tests

Will be able to resolve these as main specification PR progresses and bids-examples are added.

@mszinte Looking forward to the specification and examples PR. If you have any questions about whats going on here let me know.

@sappelhoff sappelhoff marked this pull request as draft July 21, 2022 16:03
@sappelhoff sappelhoff added the BEP ongoing BIDS Extension Proposal label Jul 21, 2022
@Remi-Gau Remi-Gau mentioned this pull request Nov 28, 2023
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BEP ongoing BIDS Extension Proposal legacy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants