BEP032: ephys -> {icephys, ecephys} #1806
Open
+41
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarikoptic
requested review from
TheChymera,
bendichter,
lzehl,
twachtler and
SylvainTakerkart
and removed request for
erdalkaraca and
tsalo
|
Looks good to me. |
TheChymera
previously approved these changes
Apr 29, 2024
|
Pending of course potential updates from the discussion. |
|
@yarikoptic Do you intend to fix this up according to #1800 (comment) or should we close this? |
|
let me fix it up to reflect #1800 ... will do now |
yarikoptic
changed the title
yarikoptic
commented
May 20, 2024
…lectrode Electrophysiology bids-standard#1800 (comment) Consensus reached during working group meeting on 2024-05-15: - modality = "Microelectrode Electrophysiology" - datatypes = "icephys" and "ecephys" - suffixes = "_icephys" and "_ecephys"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
Didn't want to push to bep032 since not yet agreed upon by @bids-standard/bep032 but wanted to be ready when/if we decide to proceed.
Closes #1800