Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faraday 2 support (update CI and dependencies) #21

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Conversation

iMacTia
Copy link
Collaborator

@iMacTia iMacTia commented Mar 19, 2024

Summary

This PR refreshes outdated development dependencies and more notably sets Ruby 3.0 as the minimum Ruby version (this will likely warrant a new major release). The reason is that Ruby 3.0 is nearing EOL already, and Faraday 2.0 does not support Ruby 2.7 or earlier.

CI has also been improved to test the correct Ruby versions, as well as adding a dimension to test both Faraday 1.x and 2.x

@iMacTia iMacTia self-assigned this Mar 19, 2024
@iMacTia iMacTia mentioned this pull request Mar 19, 2024
@iMacTia
Copy link
Collaborator Author

iMacTia commented Mar 19, 2024

@bhaberer Would you like to review PRs before merging or do you prefer a more hands-off approach?
I understand you're not using the library anymore, but it's still under your name so happy either way 🙂

@iMacTia
Copy link
Collaborator Author

iMacTia commented Mar 19, 2024

Btw I wasn't expecting all tests to pass with Faraday 2.0 🤔
I've reached out to @rgaufman to understand what issues he's running into when using it with Faraday 2

@rgaufman
Copy link

rgaufman commented Apr 7, 2024

Sorry for the late reply, I just assumed because of the documentation it won't work, I never actually tried it! - I just did and so far it seems to be working, thank you!

@bhaberer bhaberer self-requested a review April 10, 2024 19:06
Copy link
Owner

@bhaberer bhaberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@iMacTia
Copy link
Collaborator Author

iMacTia commented Apr 11, 2024

Glad to hear the current version is working already, we can still merge this and might not even need to release a new major version because bundler should be smart enough to just ignore it if you're running an older Ruby 👍

@iMacTia iMacTia merged commit ce6fded into master Apr 11, 2024
16 checks passed
@iMacTia iMacTia deleted the mg/faraday-2-support branch April 11, 2024 10:00
@bhaberer
Copy link
Owner

@iMacTia @rgaufman FYI, will probably tag head as v0.5.0 and push a new version to rubygems tonight/this weekend unless either of you object :) Thanks again for the help!

@rgaufman
Copy link

No objections from me and much appreciated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants