Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WG] unit_stateprefs.lua - Use bindable action instead of CTRL modifier to activate recording mode #2859

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[WG] unit_stateprefs.lua - Use bindable action instead of CTRL modifier to activate recording mode #2859

wants to merge 2 commits into from
+27 −8

Conversation

lokimckay
Copy link
Contributor

Use bindable action instead of CTRL modifier to activate recording mode

Work done

  • Add stateprefs_record action and handlers
  • Remove default CTRL modifier check

@lokimckay
Update unit_stateprefs.lua
983063f 
Use bindable action instead of CTRL modifier to activate recording mode
thehobojoe
thehobojoe requested changes Apr 21, 2024
View reviewed changes
Copy link
Collaborator

@thehobojoe thehobojoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description should be updated to indicate that they need to bind something to use this now

@lokimckay
Copy link
Contributor Author

Thanks @thehobojoe, updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thehobojoe thehobojoe Awaiting requested review from thehobojoe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lokimckay @thehobojoe