Mission API #2809
Draft
Mission API #2809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed all allocations and string concatenation made in widget:DrawScreen, the messages never change after game start so this was unnecessary - Moved scaling calculations from widget:DrawScreen to widget:ViewResize. This is the only time the size will change Reduced runtime allocation to 0, from ~1500 kB/s, and reduced usage by ~1%
- Fixed styling - Blink was repeatedly reformatting string each frame unnecessarily
- spawnUnits and despawnUnits now handle quanitity
- Added validation checking for unit, unitDef, vec3 and direction parameter types - Added actions_defs.lua for storing parameter enums
- TrackedUnits is now always an array to simplify implementations, and allow single units to be added to a tracked name
Implemented UnitExists, UnitNotExists, UnitKilled, UnitCaptured, UnitEnteredLocation, ConstructionStarted and Construction Finished triggers Implemented Custom action
Mission API dev work from @Psyborg8's fork.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work done
@Psyborg8's work done on the mission API:
Test steps
api_missionssingleplayer/test_mission.luaare hit