Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Try snapshot tests #3623

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Conversation

n0izn0iz
Copy link
Contributor

@n0izn0iz n0izn0iz commented Nov 3, 2021

No description provided.

@n0izn0iz n0izn0iz self-assigned this Nov 3, 2021
@n0izn0iz n0izn0iz requested a review from a team as a code owner November 3, 2021 09:04
@trafico-bot trafico-bot bot added the 🚧 WIP label Nov 3, 2021
@n0izn0iz n0izn0iz force-pushed the snapshot-tests branch 2 times, most recently from a86d65d to 4db3fd9 Compare November 3, 2021 09:06
@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #3623 (bed0f41) into master (8da06a6) will increase coverage by 1.03%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3623      +/-   ##
==========================================
+ Coverage   29.84%   30.87%   +1.03%     
==========================================
  Files         372      374       +2     
  Lines       32628    32639      +11     
  Branches     1740     1747       +7     
==========================================
+ Hits         9738    10078     +340     
+ Misses      21619    21290     -329     
  Partials     1271     1271              
Flag Coverage Δ
js.unittests 15.38% <71.42%> (+4.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../packages/components/chat/message/AudioMessage.tsx 38.23% <0.00%> (+30.65%) ⬆️
js/packages/testutil/fixtures.tsx 100.00% <100.00%> (ø)
js/packages/testutil/index.tsx 100.00% <100.00%> (ø)
js/packages/store/utils.ts 9.37% <0.00%> (-1.74%) ⬇️
js/packages/components/chat/SharedMedias.tsx 3.70% <0.00%> (-0.15%) ⬇️
js/packages/components/chat/MessageList.tsx 4.34% <0.00%> (-0.07%) ⬇️
...es/components/chat/file-uploads/GallerySection.tsx 3.12% <0.00%> (ø)
...s/components/modals/ForwardToBertyContactModal.tsx 3.33% <0.00%> (+0.76%) ⬆️
...s/packages/components/chat/message/FileMessage.tsx 4.54% <0.00%> (+0.84%) ⬆️
js/packages/styles/map-border.ts 83.33% <0.00%> (+8.33%) ⬆️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8da06a6...bed0f41. Read the comment docs.

Signed-off-by: Norman Meier <norman@berty.tech>
Signed-off-by: Norman Meier <norman@berty.tech>
Signed-off-by: Norman Meier <norman@berty.tech>
Signed-off-by: Norman Meier <norman@berty.tech>
Signed-off-by: Norman Meier <norman@berty.tech>
@n0izn0iz n0izn0iz marked this pull request as draft November 15, 2021 07:40
@jefft0 jefft0 requested review from jefft0 and removed request for a team April 19, 2023 08:30
@jefft0 jefft0 removed the 🚧 WIP label Apr 21, 2023
@jefft0 jefft0 removed their request for review April 21, 2023 12:40
@trafico-bot trafico-bot bot added the 🚧 WIP label Apr 21, 2023
@jefft0 jefft0 removed the 🚧 WIP label Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants