Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom service jellystat #770

Merged
merged 3 commits into from
Jun 1, 2024
Merged

Conversation

TheWhale01
Copy link
Contributor

Description

I've added support for Jellystat custom service. Jellystat is for Jellyfin what Tautulli is to Plex, so I found interesting to add this service to homer. It displays the number of current streams from your Jellyfin server, just like Tautulli does.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've read & comply with the contributing guidelines
  • I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • I have made corresponding changes to the documentation (README.md).
  • I've checked my modifications for any breaking changes, especially in the config.yml file

Copy link

netlify bot commented Apr 21, 2024

Deploy Preview for homer-demo-content failed.

Name Link
🔨 Latest commit 711f873
🔍 Latest deploy log https://app.netlify.com/sites/homer-demo-content/deploys/665b2b82440af8000836d1c0

Copy link
Owner

@bastienwirtz bastienwirtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @TheWhale01 ! I rebased your branch with the latest change to fix merge conflict.
A few little things to fix and we should be good 👍

src/components/services/Jellystat.vue Outdated Show resolved Hide resolved
// Since there is no proper endpoint to get the number of current
// streams, so we have to do a little bit of searching.
for (let stream of this.stats) {
console.log(stream);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debug log to remove

};
try {
const response = await this.fetch(
`/proxy/getSessions`, { headers });
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for string interpolation here

Suggested change
`/proxy/getSessions`, { headers });
'/proxy/getSessions', { headers });

}
}
}
</style>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing EOF

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you remove this file ? (might be here because of the rebase, not sure)

Copy link
Owner

@bastienwirtz bastienwirtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, everything looks good 👍

@bastienwirtz bastienwirtz merged commit 95fde89 into bastienwirtz:main Jun 1, 2024
0 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants