Allow secondary location for intercepts. #818
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the configuration to specify an alternative location for intercept files, instead of assuming that they are located with riak_test/intercepts; this allows projects to keep related intercepts locally.
|
cc: @macintux |
| @@ -51,7 +51,7 @@ get_os_env(Var, Default) -> | |||
|
|
|||
| %% @doc Load the configuration from the specified config file. | |||
| load(Config, undefined) -> | |||
| load(Config, filename:join([os:getenv("HOME"), ".riak_test.config"])); | |||
| load(Config, filename:join([os:getenv("PWD"), ".riak_test.config"])); | |||
There was a problem hiding this comment.
I understand the motivation, but shouldn't this be additive? Check pwd first, if it's not there, check HOME?
There was a problem hiding this comment.
This change shouldn't have made it in; this is a Lasp-specific change.
|
Once you've reverted the PWD/HOME bit, this looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the configuration to specify an alternative location for intercept files, instead of assuming that they are located with riak_test/intercepts; this allows projects to keep related intercepts locally.