Updated PR for SecondaryIndexQueries #1783
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `extract_buckets` primitive takes a map. This map can either work on ranges, or just values or possibly later regexp etc, like the filters. This is not clearly written down and for the moment I define the `extract_buckets` to always work on a map of ranges. Some thought need to go into how to represent the different alternatives
martinsumner
reviewed
Feb 8, 2021
There was a problem hiding this comment.
I'm not sure it works to split out the process of breaking up a fixed width index by first adding a delimiter - as the index being split may contain the delimiter.
Perhaps supporting fixed width is an unnecessary complication. Perhaps delimiters should always be used, and all binary parts on the index should be expected to be base64 encoded. The indexes are compressed before storage, so being able to fine tune there size is perhaps a false saving.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.