Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce JsonUnit and a bunch KV related functions to simplify itests. #703

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

srgg
Copy link
Contributor

@srgg srgg commented Mar 17, 2017

Description

The PR introduces (JsonUnit)[https://github.com/lukas-krecan/JsonUnit] library which is used to make assertions.

Motivation and Context

Sometimes it is hard to read test tons of assertions in test cases, especially when it is required to check more or less complex objects. This PR demonstrates how Json may simplify testing and make test cases more human readable.

How Has This Been Tested?

The modified test is still green.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ x] My code follows the code style of this project.
  • [ x] I have read the CONTRIBUTING document.
  • [ x] I have added tests to cover my changes.
  • [ x] All new and existing tests passed.
  • [ x] Javadoc comments for any new public classes, interfaces, etc.
  • A basho_docs PR for new or changed features (basho/basho_docs#???)

Pull requests that are small and limited in scope are most welcome.

@srgg srgg requested a review from alexmoore March 17, 2017 13:19
@srgg srgg force-pushed the feature/srgg/test-simplification branch from 72e525b to a1f7b4b Compare March 17, 2017 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant