Riak Delete-Create Operation #165
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 26, 2015 12:39
feedback from Jon that one get would be sufficent to guarentee the reap
…n from functioning properly
…n from functioning properly ...
|
If the key already exists, the last clause of maybe_put is going to create a sibling because it's a fresh put. (Assuming allow_mult=true) The delete tombstone from the delete would create another sibling, and the immediate delete that you're hoping for won't happen. When siblings are possible, your best bet is to get the vclock of the existing key and use it for If allow_mult=false and lww=true, then you ought to get what you're expecting. |
|
ping? |
|
Monthly ping? |
|
ping? |
|
@JeetKunDoug Would you mind having one of your KV folks take a peek at this PR and decide if it's still relevant? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an operation to the Riak driver that puts a key, deletes it (and ensures that it has been removed from disk), and then puts the key again. It requires that all nodes in the Riak cluster are configured with delete mode immediate.
This PR is not yet ready to be merged. I am opening it to get initial feedback from @jonmeredith and will further refine.