Sbt 1.0 and version upgrades, scala.js test fixes #333

bastiion · 2017-12-01T14:29:29Z

While working on a jsonld.js feature I recognized that none of the scala.js code was actually beeing tested. There were some mistakes in the way how the jsonld.js resource was beeing loaded (it coudln't be referenced in an node.js environment because you have to specify it commonJSName).
Furthermore dependencies of scala.js crossprojects have to be specified with "org.organisation" %%% "package" % "0.0" this cannot not be done in Dependencies.scala.

In general I thought it was time to leverage the build chain, to use the latest sbt version and the plugin-dependencies.

Unfortunatly I coudln't get unidoc working at the moment. Further investigation is necessary, what needs to be aggregated and excluded.

- fixed all things, that preveted tests on node.js from running - unidoc currently not working (needs configuration)

…iform

- scalazVersion and ScalatestVersion to refer to these libraries with %%% - version bumps of scalaz, scalatest and akkaHttpCore

- with minor modifications to allow loading in node.js testing environment and in browser test - master branch of http://github.com/digitalbazaar/jsonld.js (commit id 3f0ad206db4e863222765e4289fe756b3f80d753)

bastiion · 2017-12-01T14:30:42Z

jsonld.js/src/main/scala/org/w3/banana/jsonldjs/JsonLdJs.scala

@@ -44,13 +44,13 @@ object jsonldHelper {
 }

 @js.native
+@JSGlobal


This will be mandadory in scala.js-1.0

bastiion · 2017-12-01T14:31:56Z

jsonld.js/src/test/scala/org/w3/banana/jsonldjs/io/JsonLdJsParserTest.scala


 import scalajs.concurrent.JSExecutionContext.Implicits.queue
 import org.w3.banana.plantain._

-object JsonLdJsParserTest extends WordSpec with Matchers {
+class JsonLdJsParserTest extends WordSpec with Matchers {


object test-suites are not executed by scalatest in js-environments

bblfish · 2017-12-06T15:35:01Z

jsonld.js/src/test/scala/org/w3/banana/jsonldjs/io/JsonLdJsParserTest.scala

-      ).graph
+        -- schema("name") ->- "Manu Sporny"
+        -- schema("url") ->- URI("http://manu.sporny.org/")
+        -- schema("image") ->- URI("http://manu.sporny.org/images/manu.png")).graph



I am not sure the above is an improvement...

this is the result of scalariform run, we can omit that (maybe we have to tune default settings?)

bblfish · 2017-12-06T15:41:24Z

jsonld.js/src/test/scala/org/w3/banana/jsonldjs/JsonLdJsTest.scala

@@ -1,13 +1,13 @@
 package org.w3.banana
 package jsonldjs

-import org.scalatest.{Matchers, WordSpec}
+import org.scalatest.{ Matchers, WordSpec }


I was looking for the style guidelines to check if we really had decided to put spaces after the squigly brackets... I would not otherwise know to decide which was better.

bblfish · 2017-12-06T15:48:23Z

build.sbt

@@ -88,7 +90,7 @@ lazy val rdf = crossProject
  .settings(commonSettings: _*)
  .settings(
    name := "banana-rdf",
-    libraryDependencies += scalaz
+    libraryDependencies += "org.scalaz" %%% "scalaz-core" % scalazVersion


why do you remove the scalaz val defined in project/Dependencies.scala?

see my comment below

bblfish · 2017-12-06T15:50:50Z

build.sbt

@@ -112,7 +114,7 @@ lazy val rdfTestSuite = crossProject
  .settings(commonSettings: _*)
  .settings(
    name := "banana-test",
-    libraryDependencies += scalatest,
+    libraryDependencies += "org.scalatest" %%% "scalatest" % scalatestVersion,


why this change? The scalatest val is still available in project/Dependencies.scala as far as I can see reading the web view here.

It is because in Dependencies.scala there is a statement:

Note: %%% can only be used within a task or setting macro, such as :=, +=, ++=, Def.task, or Def.setting...

Yesterday I read at the scala-js gitter channel:

Ah, in a .scala file you need an additional import: import org.portablescala.sbtplatformdeps.PlatformDepsPlugin.autoImport._

I already tested but it is still not working stating:

Dependencies.scala:33:47: value %%% is not a member of String

This is one of the root causes, that tests aren't running and scala-js dependecies are not set correctly (which is especially bad if a library wants to use banana-rdf-sjs without manually adding scalaz)

It seems to be used here
https://github.com/portable-scala/sbt-crossproject/blob/master/sbt-crossproject/src/main/scala/sbtcrossproject/CrossPlugin.scala
and here
https://github.com/scala-js/scala-js/blob/master/sbt-plugin/src/main/scala/org/scalajs/sbtplugin/ScalaJSPluginInternal.scala

The %%% method is defined there, with private[sbtplatformdeps] in its parent class signature.

https://github.com/portable-scala/sbt-platform-deps/blob/master/src/main/scala/org/portablescala/sbtplatformdeps/PlatformDepsBuilders.scala

Until we know how to declare it in project/Dependecies.scala, IMHO we should take the imperfect solution, as the current release of banana-rdf can be considered broken - sjs-libs are neither tested nor are they published with correct dependencies.

ok, just open an issue and link to it, in the dependencies with the explanation. Then it will be easier to remember to do something when the right time comes.

bblfish · 2017-12-06T15:56:06Z

build.sbt

-lazy val jsonldJS = Project("jsonld", file("jsonld.js"), settings = commonSettings)
+lazy val jsonldJS = Project("jsonld", file("jsonld.js"))
+  .settings(commonSettings: _*)
+  .settings()


is this empty settings doing any work?

no, this is a mistake

ok, should be fixed then for the PR to go through :-)

bblfish · 2020-09-04T08:22:35Z

Hi @bastiion have the lastest big PRs addresses the issues that you described in here? Should I close it?

bastiion added 4 commits December 1, 2017 15:03

updated sbt to 1.0.4 and all sbt-plugins to newest versions

76c4352

- fixed all things, that preveted tests on node.js from running - unidoc currently not working (needs configuration)

converted Test Suites from object to class and reformated with scalar…

13ad6f0

…iform

missing changes from Dependencies.scala

68664a9

- scalazVersion and ScalatestVersion to refer to these libraries with %%% - version bumps of scalaz, scalatest and akkaHttpCore

latest jsonld.js javascript-library updated

1e8fc67

- with minor modifications to allow loading in node.js testing environment and in browser test - master branch of http://github.com/digitalbazaar/jsonld.js (commit id 3f0ad206db4e863222765e4289fe756b3f80d753)

bastiion commented Dec 1, 2017

View reviewed changes

bblfish reviewed Dec 6, 2017

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sbt 1.0 and version upgrades, scala.js test fixes #333

Sbt 1.0 and version upgrades, scala.js test fixes #333

bastiion commented Dec 1, 2017

bastiion Dec 1, 2017

bastiion Dec 1, 2017

bblfish Dec 6, 2017

bastiion Dec 6, 2017

bblfish Dec 6, 2017

bblfish Dec 6, 2017 •

edited

bastiion Dec 6, 2017

bblfish Dec 6, 2017

bastiion Dec 6, 2017

bblfish Dec 6, 2017

bastiion Dec 7, 2017

bblfish Dec 7, 2017

bblfish Dec 6, 2017

bastiion Dec 6, 2017

bblfish Dec 12, 2017

bblfish commented Sep 4, 2020

Sbt 1.0 and version upgrades, scala.js test fixes #333

Are you sure you want to change the base?

Sbt 1.0 and version upgrades, scala.js test fixes #333

Conversation

bastiion commented Dec 1, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bblfish Dec 6, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bblfish commented Sep 4, 2020

bblfish Dec 6, 2017 •

edited