Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitbucketpipelines] resolve "invalid response data" for halted pipelines #9472

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

reeceappling
Copy link

Should resolve issue #9096
Bitbucket responses for pipelines in progress will now fall back to utilizing the stage name instead of being invalid.

@github-actions
Copy link
Contributor

Messages
📖 ✨ Thanks for your contribution to Shields, @reeceappling!

Generated by 🚫 dangerJS against 73e4a4b

@reeceappling
Copy link
Author

It appears to be failing due to some missing credentials. Not sure what needs to be done about that...

@calebcartwright
Copy link
Member

Thanks for the PR!

It appears to be failing due to some missing credentials. Not sure what needs to be done about that...

in CI we funnel the test output to a different area where it's easier to consume, the console output about the credentials is unrelated. You can find the test failures in the summary for the PR at https://github.com/badges/shields/actions/runs/5843476444/attempts/1#summary-15845658997, and imo from a quick glance, the failures do seem highly likely related to the proposed changes.

@calebcartwright calebcartwright added the service-badge Accepted and actionable changes, features, and bugs label Aug 12, 2023
@reeceappling
Copy link
Author

Sweet, thanks for the explaination, I'll have time to check it out tomorrow.

@chris48s chris48s changed the title [BitBucket] resolve "invalid response data" for halted pipelines [bitbucketpipelines] resolve "invalid response data" for halted pipelines Aug 13, 2023
@chris48s
Copy link
Member

I think this PR does introduce a failure.

But also unfortunately Bitbucket does have some failing tests anyway, so we are not starting from a point where everything passes with this one.

I've updated the PR title to only run the tests for BB pipelines. Lets take failing issues tests out of the equation as they're not being touched here.

The baseline for this service is

  • 9 passing
  • 2 failing

with the failures on

  • Bitbucket Pipelines [live] branch build result (valid)
  • Bitbucket Pipelines [live] branch build result (never built)

because the upstream repo we were testing against has been deleted. To fix those, we need to find or make another repo for those tests, or switch them to mocked tests.

so I think for this PR if we can keep everything else passing that is OK for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants