Add patch for projection onto NC internal boundaries #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like to include this in v0.13 release. Can you rebase once we merge #247 and update the Changelog? |
sebastiangrimberg
force-pushed
the
hughcars/nc-electrostatics-fix
branch
from
86dc3ad
to
ac75945
Compare
|
Marked as ready now that mfem/mfem#4259 is in review. |
sebastiangrimberg
force-pushed
the
hughcars/nc-electrostatics-fix
branch
from
e8d9c09
to
b8d4613
Compare
sebastiangrimberg
added
amr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a patch to mfem for nc internal boundaries, where for electrostatics internal boundary conditions would fail to project onto NC refined faces where face dof were present (p > 3). The patch is addressed against mfem at mfem/mfem#4259.
Before:
After:
