Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lambda): add domainName prop to FunctionUrl #30198

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mbfreder
Copy link

Issue # (if applicable)

Closes #23005.

Reason for this change

This change is to address this issue

Description of changes

This PR adds a new property called domainName to the FunctionUrl construct. The goal is to make it easy for customers to get the domain name directly (FunctionUrl.domainName) instead of first getting the url (FunctionUrl.url) and then removing the scheme and the trailing slash.
The README has been updated.

Description of how you validated changes

I Added some unit tests. I Don't think integration tests are necessary in this case.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label May 15, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team May 15, 2024 00:42
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label May 15, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 88a4da2
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mbfreder mbfreder changed the title feat(lambda): Add domainName prop to FunctionUrl feat(lambda): add domainName prop to FunctionUrl May 15, 2024
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@mbfreder
Copy link
Author

I don't think integration tests are needed in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(lambda): Add domain helper prop to FunctionUrl
2 participants