-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve pkg config #128
base: master
Are you sure you want to change the base?
Improve pkg config #128
Conversation
* configure.ac: Record the computed Requires.private values in the REQUIRES_PRIVATE configure variable. * autotrace.pc.in: Use it as the value for a new Requires.private field. Remove Libs.private and extraneous flags from Cflags. Fixes: autotrace#124
I'm investigating why CMake prints the following as part of the Inkscape build, following this change:
This is emitted when |
That's probably expected and non-fatal; CMake invokes both pkg-config with and without |
Funny, the freedesktop
|
Here's the report I've sent to CMake: https://gitlab.kitware.com/cmake/cmake/-/issues/25692 |
@Apteryks doesn't pass the tests. Could you please take a look? |
Otherwise, libraries linking to libautotrace.so would not find the symbols needed (in a situation where the .la file is not used and it is expected that a RUNPATH was written to the ELF object of the library). * Makefile.am (autotrace_LDADD): Move library link directives to... (libautotrace_la_LDFLAGS): ... here. (autotrace_LDFLAGS): New variable. Relates-to: autotrace#124
8d7c808
to
bee3b69
Compare
Hi! Weird, since it works on my Guix system. Perhaps the ld wrapper used in Guix that adds -rpath arguments for each library directory corresponding to each linked library is the reason. I've added this line to the Makefile.am:
noting that src/main.c uses glib too. I hope it resolves it! |
I think this is an improvement on the current state of things.
I haven't successfully built Inkscape with it yet, but it seems the issue may be more with my packaging of Inkscape or its build system.