Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

af: Add symlinks to ios and macos [SDK-4693] #350

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

Widcket
Copy link
Collaborator

@Widcket Widcket commented Nov 20, 2023

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

📋 Changes

This PR symlinks all the files within the darwin directory into the ios and macos directories. This is necessary because pub does not support symlinking directories, so each file has to be symlinked individually.

The .gitignore file inside darwin was copied instead of symlinked, because of Git behavior:

Screenshot 2023-11-20 at 13 06 15

Commits:

  • 4139430 adds the symlinks to the ios directory
  • a2091c2 adds the symlinks to the macos directory

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (feature/macos-support@b2370e5). Click here to learn what that means.

Additional details and impacted files
@@                   Coverage Diff                    @@
##             feature/macos-support     #350   +/-   ##
========================================================
  Coverage                         ?   96.36%           
========================================================
  Files                            ?       98           
  Lines                            ?     1596           
  Branches                         ?      328           
========================================================
  Hits                             ?     1538           
  Misses                           ?       50           
  Partials                         ?        8           
Flag Coverage Δ
auth0_flutter 100.00% <0.00%> (?)
auth0_flutter_android 97.35% <0.00%> (?)
auth0_flutter_ios 99.85% <0.00%> (?)
auth0_flutter_platform_interface 87.03% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Widcket Widcket changed the title Add symlinks to ios and macos [SDK-4693] af: Add symlinks to ios and macos [SDK-4693] Nov 20, 2023
@Widcket Widcket merged commit 4fcb8b0 into feature/macos-support Nov 21, 2023
12 checks passed
@Widcket Widcket deleted the macos-support/add-symlinks branch November 21, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:small Small review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants