Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Confluence] Expand parameter addition for get_draft_page_by_id #1388

Merged
merged 4 commits into from
May 16, 2024

Conversation

austinmh12
Copy link
Contributor

get_draft_page_by_id calls the same endpoint as get_page_by_id but with the status defaulted to draft. Updated the underlying function to just forward the params to get_page_by_id which allows the expand and version parameter to be passed as well, though I only added the expand parameter to get_draft_page_by_id since the versioning is a bit different than the standard page versioning.

@austinmh12 austinmh12 marked this pull request as draft May 14, 2024 15:28
@austinmh12 austinmh12 changed the title Updated get_draft_page_by_id to call get_page_by_id and added expand param [Confluence] Expand parameter addition for get_draft_page_by_id May 14, 2024
@austinmh12 austinmh12 marked this pull request as ready for review May 14, 2024 15:39
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 34.07%. Comparing base (413524b) to head (b714eed).
Report is 9 commits behind head on master.

Files Patch % Lines
atlassian/confluence.py 50.00% 1 Missing ⚠️
atlassian/jira.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1388      +/-   ##
==========================================
- Coverage   34.14%   34.07%   -0.07%     
==========================================
  Files          46       46              
  Lines        8444     8472      +28     
  Branches     1190     1195       +5     
==========================================
+ Hits         2883     2887       +4     
- Misses       5446     5469      +23     
- Partials      115      116       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gonchik gonchik merged commit 588f365 into atlassian-api:master May 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants