-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rest client: Only enable backoff_and_retry
if urllib3
is at least 2.0.0
#1342
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1342 +/- ##
==========================================
+ Coverage 34.16% 34.19% +0.02%
==========================================
Files 45 46 +1
Lines 8373 8428 +55
Branches 1177 1185 +8
==========================================
+ Hits 2861 2882 +21
- Misses 5397 5431 +34
Partials 115 115 ☔ View full report in Codecov by Sentry. |
This is problematic for companies using RHEL. urllib3>2.0 requires a version of libssl that is not available on older (but still supported releases) or RHEL. |
Ok, I'll look into alternative options. Thanks. |
e49a8b8
to
6a9d6ba
Compare
urllib3
of 2.0.0backoff_and_retry
if urllib3
is at least 2.0.0
Here is another option I thought of. Hacky, but at least it won't fail is |
8629633
to
1f9b87f
Compare
…at least version `2`.
1f9b87f
to
26ab8c0
Compare
@gonchik can I get a review on this? |
@djgoku I did not check on the RHEL 7 yet. , I will come back once it's ready |
We are trying to use
backoff_and_retry
but are getting errors with urllib3 1.26.X this fixes and sets the minimum ofurllib3
to>= 2.0.0
The first release supporting
backoff_jitter
in theRetry
class is the2.0.0
release.https://github.com/urllib3/urllib3/releases/tag/2.0.0
It doesn't look like this will be added to
1.26.X
urllib3/urllib3#2952 (comment)