Linelists: make lookuptables a little more robust #2901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2901 +/- ##
==========================================
- Coverage 67.23% 67.23% -0.01%
==========================================
Files 235 235
Lines 18155 18159 +4
==========================================
+ Hits 12207 12209 +2
- Misses 5948 5950 +2 ☔ View full report in Codecov by Sentry. |
bsipocz
requested changes
Dec 19, 2023
|
|
||
| """ | ||
|
|
||
| if s in self: |
There was a problem hiding this comment.
ahh, my eyes hurt, could we make this called something longer than s? I suspect that would mean a deprecation--rename?
There was a problem hiding this comment.
we renamed it to st in the other instance. But this particular argument is barely user-facing; I don't know that we need to deprecate it
|
This should probably go into a slightly larger refactor too:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lookuptables used in linelist searches are a little touchy because of lines like
HCO+andHOCO+. You have to escape the+'s to get them to work, which means that even exact matches to molecules, like29002 HCO+ v=0,1,2will not work.This change means that exact matches will work, while partial matches will still need to be escaped.