DEP: CFITSIO 4.4.0

[pllim]

Description

This pull request is to bump to CFITSIO 4.4.0. No functional changes to astropy, theoretically, so no need for change log.

• By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

[github-actions]

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

• Do the proposed changes actually accomplish desired goals?
• Do the proposed changes follow the Astropy coding guidelines?
• Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
• Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
• Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
• Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
• Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
• Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
• At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

[eerovaher]

@olebole, do you know what Debian thinks of this license?

[pllim]

@eteq is passionate about license too, so also pinging him.

[olebole]

This license is approved by OSI: https://opensource.org/license/nasa1-3-php, but Debian sees it as not compliant to its guidelines: https://lists.debian.org/debian-legal/2011/04/msg00075.html.
I would prefer to have this rejected; specifically because there is no functional change at all. I am not sure whether the Debian cfitsio maintainer had a discussion with upstream yet.

[pllim]

😱

Do you think CFITSIO would get rid of this license in the next release? Given that it is distributed by NASA (https://heasarc.gsfc.nasa.gov/fitsio/), seems unlikely.

[eerovaher]

From what I can tell 4.4.0 is the first release under the new license, so bundling 4.3.1 should be uncontroversial.

[olebole]

I asked our Debian maintainer Aurelien Jarno about wether he already contacted upstream (cc to our list). For me the license compliance situation is a bit unclearer: originally it was set as "non-compliant", but the mentioned mail thread questions this (without a definitive outcome IMO). Let's see what he says and whether we could/should contact upstream.

[lpsinger]

FYI, I am speaking with upstream and with my management at NASA to find out more about this.