Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: adapt a coordinates test to numpy 2 #16427

Merged

Conversation

neutrinoceros
Copy link
Contributor

@neutrinoceros neutrinoceros commented May 9, 2024

Description

This pull request is to address part of #16423 (specifically coordinates).

The first commit is shared with #16426 so there should be no conflicts between these two.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

Copy link

github-actions bot commented May 9, 2024

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

Copy link

github-actions bot commented May 9, 2024

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@neutrinoceros neutrinoceros force-pushed the coordinates/compat/test/numpy2_compat branch from 17355eb to a48eac9 Compare May 14, 2024 06:24
@neutrinoceros
Copy link
Contributor Author

The io.misc label should be removed.

@pllim pllim added backport-v6.1.x on-merge: backport to v6.1.x and removed io.misc labels May 14, 2024
@pllim pllim modified the milestones: v7.0.0, v6.1.1 May 14, 2024
Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks uncontroversial enough now. Thanks!

@pllim pllim merged commit 233cc43 into astropy:main May 23, 2024
33 of 35 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request May 23, 2024
@neutrinoceros neutrinoceros deleted the coordinates/compat/test/numpy2_compat branch May 23, 2024 15:06
pllim added a commit that referenced this pull request May 23, 2024
…427-on-v6.1.x

Backport PR #16427 on branch v6.1.x (TST: adapt a coordinates test to numpy 2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants