Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New 4 coordinate crossmatch #566

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

luthienliu
Copy link

@luthienliu luthienliu commented Aug 6, 2022

  • Check the box to confirm that you are familiar with the contributing guidelines and/or indicate (check the box) that you are familiar with our contributing workflow.
  • Confirm that any contributed tutorials contain a complete Introduction which includes an Author list, Learning Goals, Keywords, Companion Content (if applicable), and a Summary.
  • Check the box to confirm that you are familiar with the Astropy community code of conduct and you agree to follow the CoC.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@eblur eblur requested review from adrn and kelle August 11, 2022 13:16
@adrn
Copy link
Member

adrn commented Aug 12, 2022

Hi @luthienliu! Thanks for this PR. It looks like there are some changes to a FITS-tables tutorial in the changes here. Could you please remove those changes from this PR, since I think they are in #564? You'll want to do an interactive rebase to get rid of those commits -- if you aren't sure how to do that, feel free to message me on the Astropy Slack and I can help you through it. Alternatively, I could do the rebase and push to your branch directly -- just let me know what you prefer.

@adrn adrn force-pushed the NEW_4_Coordinate_Crossmatch branch from f22d88f to d5d947d Compare August 18, 2022 02:11
@adrn
Copy link
Member

adrn commented Aug 18, 2022

Hi again @luthienliu - I went ahead and fixed the merge conflicts for you by rebasing your branch, but in doing that I noticed that you made a new duplicate version of the tutorial instead of modifying the existing 4-Coordinates-Crossmatch.ipynb file. Please copy the proposed changes into that file instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants