Use lookahead to resolve type soft keyword
#11442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvmanila
force-pushed
the
dhruv/parser-checkpoint
branch
from
270d0d7
to
fe47dce
Compare
dhruvmanila
force-pushed
the
dhruv/soft-keyword-type
branch
from
9c3967d
to
244e848
Compare
dhruvmanila
force-pushed
the
dhruv/parser-phase-2
branch
from
30ecb9c
to
bd86d41
Compare
dhruvmanila
force-pushed
the
dhruv/soft-keyword-type
branch
from
244e848
to
22f51f3
Compare
charliermarsh
approved these changes
May 20, 2024
5 tasks
dhruvmanila
added a commit
that referenced
this pull request
May 23, 2024
## Summary This PR updates the `type` alias statement parsing to use lookahead to resolve whether it's used as a keyword or as an identifier depending on the context. The strategy here is that the first token should be either a name or a soft keyword and the second can be either a `[` or `=`. Remember that `type type = int` is valid where the first `type` is a keyword while the second `type` is an identifier.
dhruvmanila
added a commit
that referenced
this pull request
May 23, 2024
## Summary This PR updates the `type` alias statement parsing to use lookahead to resolve whether it's used as a keyword or as an identifier depending on the context. The strategy here is that the first token should be either a name or a soft keyword and the second can be either a `[` or `=`. Remember that `type type = int` is valid where the first `type` is a keyword while the second `type` is an identifier.
dhruvmanila
added a commit
that referenced
this pull request
May 24, 2024
## Summary This PR updates the `type` alias statement parsing to use lookahead to resolve whether it's used as a keyword or as an identifier depending on the context. The strategy here is that the first token should be either a name or a soft keyword and the second can be either a `[` or `=`. Remember that `type type = int` is valid where the first `type` is a keyword while the second `type` is an identifier.
dhruvmanila
added a commit
that referenced
this pull request
May 27, 2024
## Summary This PR updates the `type` alias statement parsing to use lookahead to resolve whether it's used as a keyword or as an identifier depending on the context. The strategy here is that the first token should be either a name or a soft keyword and the second can be either a `[` or `=`. Remember that `type type = int` is valid where the first `type` is a keyword while the second `type` is an identifier.
dhruvmanila
added a commit
that referenced
this pull request
May 28, 2024
## Summary This PR updates the `type` alias statement parsing to use lookahead to resolve whether it's used as a keyword or as an identifier depending on the context. The strategy here is that the first token should be either a name or a soft keyword and the second can be either a `[` or `=`. Remember that `type type = int` is valid where the first `type` is a keyword while the second `type` is an identifier.
dhruvmanila
added a commit
that referenced
this pull request
May 30, 2024
## Summary This PR updates the `type` alias statement parsing to use lookahead to resolve whether it's used as a keyword or as an identifier depending on the context. The strategy here is that the first token should be either a name or a soft keyword and the second can be either a `[` or `=`. Remember that `type type = int` is valid where the first `type` is a keyword while the second `type` is an identifier.
dhruvmanila
added a commit
that referenced
this pull request
May 31, 2024
## Summary This PR updates the `type` alias statement parsing to use lookahead to resolve whether it's used as a keyword or as an identifier depending on the context. The strategy here is that the first token should be either a name or a soft keyword and the second can be either a `[` or `=`. Remember that `type type = int` is valid where the first `type` is a keyword while the second `type` is an identifier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the
typealias statement parsing to use lookahead to resolve whether it's used as a keyword or as an identifier depending on the context.The strategy here is that the first token should be either a name or a soft keyword and the second can be either a
[or=. Remember thattype type = intis valid where the firsttypeis a keyword while the secondtypeis an identifier.