Add checkpoint logic for the parser #11441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvmanila
force-pushed
the
dhruv/lazy-lexer
branch
4 times, most recently
from
47ec6fe
to
dcab2ef
Compare
dhruvmanila
force-pushed
the
dhruv/parser-phase-2
branch
from
bfc513e
to
ecd5cb2
Compare
dhruvmanila
force-pushed
the
dhruv/parser-checkpoint
branch
from
270d0d7
to
fe47dce
Compare
5 tasks
dhruvmanila
added a commit
that referenced
this pull request
May 20, 2024
## Summary This PR adds the checkpoint logic to the parser and token source. It also updates the lexer checkpoint to contain the error position.
dhruvmanila
added a commit
that referenced
this pull request
May 23, 2024
## Summary This PR adds the checkpoint logic to the parser and token source. It also updates the lexer checkpoint to contain the error position.
dhruvmanila
added a commit
that referenced
this pull request
May 23, 2024
## Summary This PR adds the checkpoint logic to the parser and token source. It also updates the lexer checkpoint to contain the error position.
dhruvmanila
added a commit
that referenced
this pull request
May 24, 2024
## Summary This PR adds the checkpoint logic to the parser and token source. It also updates the lexer checkpoint to contain the error position.
dhruvmanila
added a commit
that referenced
this pull request
May 27, 2024
## Summary This PR adds the checkpoint logic to the parser and token source. It also updates the lexer checkpoint to contain the error position.
MichaReiser
reviewed
May 27, 2024
Comment on lines
+649
to
+653
| self.tokens.rewind(checkpoint.tokens); | ||
| self.errors.truncate(checkpoint.errors_position); | ||
| self.current_token_id = checkpoint.current_token_id; | ||
| self.prev_token_end = checkpoint.prev_token_end; | ||
| self.recovery_context = checkpoint.recovery_context; |
There was a problem hiding this comment.
Nit: I like to use destructuring here. It adds a compile time guarantee that all fields are used (at the cost of a bit more code)
let ParserCheckpoint {
tokens,
errors_position,
prev_token_end,
recovery_context
} = checkpoint;
self.tokens.rewind(tokens);
self.errors.truncate(errors_position);
...You can also do the destructuring right in the method signature, although it then becomes a bit hard to read.
There was a problem hiding this comment.
Yeah, I recently realized that with the amount of fields increasing in the lexer checkpoint and will be making the changes in a follow-up PR. Thanks for the recommendation.
dhruvmanila
added a commit
that referenced
this pull request
May 28, 2024
## Summary This PR adds the checkpoint logic to the parser and token source. It also updates the lexer checkpoint to contain the error position.
dhruvmanila
added a commit
that referenced
this pull request
May 30, 2024
## Summary This PR adds the checkpoint logic to the parser and token source. It also updates the lexer checkpoint to contain the error position.
dhruvmanila
added a commit
that referenced
this pull request
May 31, 2024
## Summary This PR adds the checkpoint logic to the parser and token source. It also updates the lexer checkpoint to contain the error position.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the checkpoint logic to the parser and token source. It also updates the lexer checkpoint to contain the error position.