Restore Salsa DB for exploring Salsa further

[MichaReiser]

No description provided.

[github-actions]

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

[codspeed-hq]

CodSpeed Performance Report

Merging #11338 will not alter performance

_{Comparing red-knot-salsa (4e2ec9f) with main (9b6d2ce)}

Summary

✅ 30 untouched benchmarks

[MichaReiser]

@AlexWaygood this is where I'm currently landing on a Salsa design for a module resolver. I think it would simplify a lot for you because you no longer need to think about invalidation, Salsa will take care of that for you. The only thing necessary for this to work is that you use db.file(path).exists() to test if a file exists.

But check out resolve_module, it's now almost empty!

[AlexWaygood]

Ah, thanks for the ping. Yes, this indeed does make the code look a lot cleaner! It was making my head hurt a little bit to see all the cache-checking stuff right alongside the search-path semantics in resolve_module()

[MichaReiser]

It's a bit weird that path_to_module converts the path to a file as the very first thing only so that file_to_module then reads the path. However, for file_to_module to be a salsa query, it can only accept an ingredient as an argument and file is an ingredient but path isn't.