#6560 - EFRepositoryBase - Unnecessary call to Update or UpdateAsync causes whole entity to be marked dirty

[gentledepp]

#6560 - EFRepositoryonlyBase - if entity had to be attached, we do set its state to "Modified"

this ensures, that unnecessary calls to "UpdateAsync" result in the whole entity being set "dirty" as opposed to just the properties that changed!

[ismcagdas]

@gentledepp thank you for your contribution. When I check your PR, below unit tests are failing;

• https://github.com/aspnetboilerplate/aspnetboilerplate/blob/dev/test/Abp.Zero.SampleApp.Tests/EntityHistory/SimpleEntityHistory_Test.cs#L503
• https://github.com/aspnetboilerplate/aspnetboilerplate/blob/dev/test/Abp.Zero.SampleApp.Tests/EntityHistory/SimpleEntityHistory_Test.cs#L542

AttachIfNot returns false but Posts collection of Blog entity is modified.

[gentledepp]

Please check my changes on the tests. I tried to add comments to make my point clear.

1. Should_Write_History_For_Audited_Property_Foreign_Key_Collection
   Here, the test was wrong: it expected the Blog to be changed. But since only the FK on post was edited, there was actually no change on Blog.
   I am not sure though, if this is a requirement (having an entitychange entry for the blog with changetype "Updated" and zero edited properties)

2. Should_Write_History_For_Audited_Property_Foreign_Key_Shadow
   This test fails because of a bug in the EntityHistoryHelper!

The line comment1.Post = post2 is expected to change the entity comment1.
However, as there is no FK (PostId) defined, the entity is not touched.
Rather, the Relationship is changed.
You can read more about this here:
https://stackoverflow.com/questions/11670212/entity-framework-wont-detect-changes-of-navigation-properties/11671707#11671707

How should this be resolved?
Should we also go through the changed relationships?
In this case, an entitychange entry for the blog with changetype "Updated" and zero edited properties for testcase 1 would also be possible

[gentledepp]

The problem lies here.
In case only a relationship was changed, but none of the actual entities, we need to track the changes too.

Because comments and posts are connected using an implicit N:M table (Comments_Posts) I have no way to get all the details necessary, though.
Can you give me a suggestion in how to implement this?

I would need:
to get from the Comments_Posts EntitySet to the entities Comment and Post, but the API of ObjectStateEntry seems not to allow for that.
Otherwise I have no way of knowing whether one of those entities is actually audited or not :-|