Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify INSTALL.md #4463

Closed
wants to merge 5 commits into from

Conversation

eraychumak
Copy link

@eraychumak eraychumak commented May 12, 2024

I agree that my contributions are licensed under the Individual Contributor License Agreement V4.0 ("CLA") as stated in https://github.com/igarastudio/cla/blob/main/cla.md

I have signed the CLA following the steps given in https://github.com/igarastudio/cla#signing


Hi @dacap,

Here's a quick link to visually preview the changes to INSTALL.md:
https://github.com/eraychumak/aseprite/blob/simplify-install-guide/INSTALL.md

@eraychumak eraychumak requested a review from dacap as a code owner May 12, 2024 19:44
@dacap dacap added needs cla The full CLA signing process wasn't completed. needs different approach labels May 23, 2024
@dacap
Copy link
Member

dacap commented May 23, 2024

Hi @eraychumak, thanks for your PR. Some comments about this:

  1. I'd prefer to keep a .md file that can be read as a txt file, adding tables might make this harder to read as a regular text file.
  2. I prefer to keep the table of contents and sections are they are (although we can really find a significant improvement in the organization of the guide)
  3. A lot of information/details were lost in the guide which might not be important but I think they make sense to have them (e.g. what is the $HOME/deps/skia dir, etc.)

I'm closing this PR and you can create an issue to talk about any change you're planning in the guide and why do you think it simplifies some specific section. But please don't rewrite the whole guide or send a new PR rewriting the whole guide before asking.

@dacap dacap closed this May 23, 2024
@eraychumak eraychumak deleted the simplify-install-guide branch May 23, 2024 18:23
@eraychumak
Copy link
Author

Hi @dacap, no worries. I'll do that next time, thank you! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs cla The full CLA signing process wasn't completed. needs different approach
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants