Treeutil cleanup #1719
Draft
Treeutil cleanup #1719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braingram
force-pushed
the
treeutil_cleanup
branch
from
a2039c5
to
eaff046
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based off changes in: #1716
Requires: spacetelescope/stdatamodels#244MergedThis PR is work towards cleaning up
asdf.treeutil. By:get_childrenandis_containerjson_idargument for callbacks provided towalk_and_modify(more on this below)The tracking needed for and the use of
json_idopens up the possibilities for bugs when not parsing schemas (see #1715 and spacetelescope/stdatamodels#244). Removing this feature would make further improvements totreeutileasier (like those that might be required for superdictionaries).A separate PR will attempt to deprecate
ignore_implicit_conversionwhich might include deprecating the AsdfFile argument ignore_implicit_conversion. This will require further investigation and more extensive changes.Checklist: