Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an ISO3166 special case for Kosovo #447

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sam-w
Copy link

@sam-w sam-w commented Jun 29, 2021

Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC no
QA no

Description

Adds a special case for the IsISO3166Alpha2 and IsISO3166Alpha3 validators for Kosovo.

Kosovo declared independence in 2008, but we're still waiting for an official inclusion to the ISO3166 standard. In the meantime many official bodies have begun using the codes XK and XXK. An example of the prevalence of this unofficial usage is that that iOS lists XK as one of its locale codes.

Expected: IsISO3166Alpha2("XK") returns true
Actual: false

@sergeyglazyrindev
Copy link

Hello guys!
I forked this package cause owner disappeared. Hope, he will be back, but it would be easier to merge these changes back if he is back
Link to my repo: create issue there and we'll discuss it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants