Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherrypick][1.12] Revert "Event simplification conn subs (#12730)" #13352

Merged
merged 1 commit into from
May 20, 2024

Conversation

bchocho
Copy link
Contributor

@bchocho bchocho commented May 20, 2024

This reverts commit f5de760.

Description

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented May 20, 2024

@sherry-x sherry-x enabled auto-merge (squash) May 20, 2024 17:49

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on b0d58f59ce8acb7894dc3eba483f30359f1cb870

two traffics test: inner traffic : committed: 8181 txn/s, latency: 4799 ms, (p50: 4500 ms, p90: 5600 ms, p99: 11400 ms), latency samples: 3526040
two traffics test : committed: 100 txn/s, latency: 1971 ms, (p50: 1800 ms, p90: 2100 ms, p99: 6200 ms), latency samples: 1760
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.207, avg: 0.201", "QsPosToProposal: max: 0.256, avg: 0.209", "ConsensusProposalToOrdered: max: 0.433, avg: 0.413", "ConsensusOrderedToCommit: max: 0.377, avg: 0.362", "ConsensusProposalToCommit: max: 0.792, avg: 0.774"]
Max round gap was 1 [limit 4] at version 1792676. Max no progress secs was 5.156058 [limit 15] at version 1792676.
Test Ok

Copy link
Contributor

✅ Forge suite compat success on 01b24e7e3548382dd25440b39a0438a993387f12 ==> b0d58f59ce8acb7894dc3eba483f30359f1cb870

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> b0d58f59ce8acb7894dc3eba483f30359f1cb870 (PR)
1. Check liveness of validators at old version: 01b24e7e3548382dd25440b39a0438a993387f12
compatibility::simple-validator-upgrade::liveness-check : committed: 6246 txn/s, latency: 5092 ms, (p50: 4800 ms, p90: 9600 ms, p99: 10900 ms), latency samples: 243620
2. Upgrading first Validator to new version: b0d58f59ce8acb7894dc3eba483f30359f1cb870
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1783 txn/s, latency: 15930 ms, (p50: 18800 ms, p90: 21700 ms, p99: 22600 ms), latency samples: 92720
3. Upgrading rest of first batch to new version: b0d58f59ce8acb7894dc3eba483f30359f1cb870
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1704 txn/s, latency: 16513 ms, (p50: 19600 ms, p90: 23000 ms, p99: 23800 ms), latency samples: 88620
4. upgrading second batch to new version: b0d58f59ce8acb7894dc3eba483f30359f1cb870
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3547 txn/s, latency: 8880 ms, (p50: 9600 ms, p90: 12700 ms, p99: 12900 ms), latency samples: 145460
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> b0d58f59ce8acb7894dc3eba483f30359f1cb870 passed
Test Ok

@sherry-x sherry-x merged commit ac0b9df into aptos-release-v1.12 May 20, 2024
92 of 96 checks passed
@sherry-x sherry-x deleted the brian/revert-net-1-12 branch May 20, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants