-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Large Package Publishing module with e2e-move tests #13344
base: main
Are you sure you want to change the base?
Conversation
⏱️ 4h 45m total CI duration on this PR
🚨 2 jobs on the last run were significantly faster/slower than expected
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13344 +/- ##
=========================================
- Coverage 33.1% 33.1% -0.1%
=========================================
Files 1753 1753
Lines 337769 337769
=========================================
- Hits 112041 111808 -233
- Misses 225728 225961 +233 ☔ View full report in Codecov by Sentry. |
ba4f40c
to
00b8d8e
Compare
large_package_publishing
e2e-move tests…ent and use SmartTable to store code in StagingArea / added relevant test cases
00b8d8e
to
0401e12
Compare
publish_to_account: bool, | ||
publish_to_object: bool, | ||
upgrade_object_code: bool, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better to have the object publish/upgrade command in a separate API? i.e. stage_object_code_chunk
? Then we don't need to pass in all the bools in a single function.
Description
Updated
large_packages.move
module inmove-examples
for better data handling and supporting object code deployment.SmartTable
in theStagingArea
to store package code datastage_code_chunk
supports 1) deploying to a standard account 2) deploying to an object 3) upgrading object codeAdded e2e-move tests for publishing large packages using
large_packages.move
with following test cases:Next Steps
Deploy
large_packages.move
:CLI Command Updates:
--chunked
) toaptos move publish
andaptos move create-object-and-publish-package
to support utilizinglarge_packages.move
for publishing large packages from the CLI. (cc. @JohnChangUK )SDK Updates:
Option
Move type, as the entry functionlarge_packages::stage_code_chunk
receives theOption
type.(current sequence number) + 1 + 4
will be the sequence number when the package is finally deployed.Type of Change
How Has This Been Tested?
cargo nextest run large_package_publishing
Checklist