Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove restartPolicy duplication #278

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

nekwar
Copy link

@nekwar nekwar commented Nov 23, 2022

Remove restartPolicy duplication for redisgraph container in helm templates

@nekwar
Copy link
Author

nekwar commented Nov 23, 2022

Related issue: #277

@marcinc marcinc self-requested a review November 29, 2022 17:11
Copy link
Contributor

@marcinc marcinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR @nekwar. Left a couple of small comments.

sources:
- https://github.com/appvia/krane
- https://github.com/nekwar/krane
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change can be reverted.

version: 0.1.1
appVersion: "v0.1.1"
version: 0.1.2
appVersion: "v0.1.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please stick to the v0.1.1 for now. As soon as new release goes out I'll make sure to bump it up. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants