Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docker): Reduce image size and update GECKODRIVER_VERSION ,FIRE… #28508

Merged
merged 1 commit into from
May 15, 2024

Conversation

alekseyolg
Copy link
Contributor

The image size has been reduced:

docker images | grep superset | sort -r
superset before 2fc08a37c747  42 minutes ago   1.22GB
superset after b5a833aae403   17 minutes ago   952MB

Removed build-essential it is only needed for assembly requirements/base.txt

Update GECKODRIVER_VERSION && FIREFOX_VERSION to latest

Add cache for pip install playwright
Added deletion of wget on the desired layer, before this deletion was on another layer and this led to excessive image size

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added install:dependencies Installation - Dependencies install:docker Installation - docker container labels May 15, 2024
@pull-request-size pull-request-size bot added size/M and removed size/S labels May 15, 2024
@rusackas rusackas merged commit 8f0baa4 into apache:master May 15, 2024
30 checks passed
@mistercrunch
Copy link
Member

This is nice, but likely to break things downstream for people installing drivers with c-bindings. Could be good to add a note to UPDATING.md like "build-essentials is no longer part of the base docker images, see #28508 for context and an example of how to use build-essentials without bloating your images"

@mistercrunch
Copy link
Member

Also now I'm curious to see what all is bloating that image, there are some great tools out there to analyze this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
install:dependencies Installation - Dependencies install:docker Installation - docker container size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants