Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: creating a redirect for a legacy link about pre-commit hook #28499

Merged
merged 1 commit into from
May 15, 2024

Conversation

rusackas
Copy link
Member

SUMMARY

I google for the pre-commit hook docs all the time, and Google thinks it's a dead-end. Hopefully this fixes it.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added the doc Namespace | Anything related to documentation label May 14, 2024
@rusackas rusackas requested a review from sfirke May 14, 2024 21:47
@rusackas rusackas merged commit 0d5f08a into master May 15, 2024
32 of 33 checks passed
@rusackas rusackas deleted the pre-commit-hooks-docs branch May 15, 2024 19:51
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
@sfirke
Copy link
Contributor

sfirke commented May 17, 2024

When should one redirect via the .htaccess file vs. in Docusaurus? Compare this to my PR here: #28496

It looks like this way supports linking to a subheading link, which had my pending PR failing CI, so maybe this is better?

@rusackas
Copy link
Member Author

I'm actually not sure... as it stands, this PR did not actually work.

https://superset.apache.org/docs/contributing/hooks-and-linting/
^^ the link here is a dead-end, as of this writing

I'm also not sure if a frontend redirect eventually teaches the googlebots where to point. One would think so.

EnxDev pushed a commit to EnxDev/superset that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Namespace | Anything related to documentation size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants