Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i18n): Adding and modifying Japanese translations #28487

Merged
merged 2 commits into from
May 16, 2024

Conversation

aikawa-ohno
Copy link
Contributor

SUMMARY

  • An unassigned translation was added.
  • Fixed translation with mismatched combinations.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added i18n Namespace | Anything related to localization i18n:japanese Translation related to Japanese language labels May 14, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.44%. Comparing base (76d897e) to head (847954f).
Report is 122 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #28487       +/-   ##
===========================================
+ Coverage   60.48%   77.44%   +16.96%     
===========================================
  Files        1931      521     -1410     
  Lines       76236    37422    -38814     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    28983    -17131     
+ Misses      28017     8439    -19578     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive ?
javascript ?
mysql 77.14% <ø> (?)
postgres 77.25% <ø> (?)
presto ?
python 77.44% <ø> (+13.96%) ⬆️
sqlite 76.70% <ø> (?)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusackas
Copy link
Member

Looks like there are some linting issues, and you'll need to run the pre-commit hook for this to pass CI.

@aikawa-ohno
Copy link
Contributor Author

Thank you for confirming.
I fixed the line endings of the .po files, which were failing the CI.

@rusackas rusackas merged commit 9924cfd into apache:master May 16, 2024
34 checks passed
@aikawa-ohno aikawa-ohno deleted the japanese branch May 17, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n:japanese Translation related to Japanese language i18n Namespace | Anything related to localization size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants