Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): use latest Ubuntu runner for CI #28441

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hainenber
Copy link
Contributor

chore(ci): use latest Ubuntu runner for CI

SUMMARY

Chore PR to keep CI up-to-date and hopefully some additional efficiency from running CI with latest Ubuntu flavor

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

All green CI can be considered as acceptance threshold

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Signed-off-by: hainenber <dotronghai96@gmail.com>
Copy link

codecov bot commented May 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.13%. Comparing base (76d897e) to head (272b165).
Report is 87 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #28441      +/-   ##
==========================================
+ Coverage   60.48%   70.13%   +9.65%     
==========================================
  Files        1931     1944      +13     
  Lines       76236    77215     +979     
  Branches     8568     8652      +84     
==========================================
+ Hits        46114    54158    +8044     
+ Misses      28017    20935    -7082     
- Partials     2105     2122      +17     
Flag Coverage Δ
hive 49.03% <ø> (-0.14%) ⬇️
javascript 57.72% <ø> (+0.01%) ⬆️
mysql 77.06% <ø> (?)
postgres 77.17% <ø> (?)
presto 53.59% <ø> (-0.21%) ⬇️
python 83.35% <ø> (+19.86%) ⬆️
sqlite 76.62% <ø> (?)
unit 58.75% <ø> (+1.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally prefer to run on a pinned version, can you update to 24.04, latest LTS?

Signed-off-by: hainenber <dotronghai96@gmail.com>
@pull-request-size pull-request-size bot added size/L and removed size/M labels May 13, 2024
@mistercrunch
Copy link
Member

I agree the decision to pin, though it'd be nice to be able to keep this DRY by referencing a variable, though I don't think there's any obvious way to do this short or implementing our own templating solution around GHA yaml (let's not do that just yet). Also would be great if something like dependabot was to submit a PR when there's a new version up.

Oh one more thing is I think we should align the base docker with CI too, but looks like GHA is mostly Ubuntu and base python images we use are Debian. I guess it show lining this up doesn't matter too much. It's kind of crazy we do all this testing on a Ubuntu base and then ship a Debian-based build into the world through docker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants