[SPARK-48312][SQL] Improve Alias.removeNonInheritableMetadata performance #46622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@agubichev, hi! Here's the improvement fix for the ultra-wide views |
agubichev
approved these changes
May 16, 2024
|
@cloud-fan PTAL |
vladimirg-db
force-pushed
the
vladimirg-db/improve-remove-non-inheritable-metadata-performance
branch
from
08ff35e
to
d2c9b52
Compare
HyukjinKwon
reviewed
May 17, 2024
HyukjinKwon
changed the title
cloud-fan
approved these changes
May 17, 2024
vladimirg-db
force-pushed
the
vladimirg-db/improve-remove-non-inheritable-metadata-performance
branch
from
d2c9b52
to
30b027c
Compare
|
thanks, merging to master! |
vladimirg-db
deleted the
vladimirg-db/improve-remove-non-inheritable-metadata-performance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Improve
Alias.removeNonInheritableMetadataperformance - avoid usingMetadataBuilderwhen there is no metadata or when there are no non-inheritable metadata keys to remove.Why are the changes needed?
In case of wide VIEWs with many Aliases this method slows down the analysis
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests
Was this patch authored or co-authored using generative AI tooling?
No