[SPARK-48159][SQL] Extending support for collated strings on datetime expressions #46618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please take a look @nikolamand-db @stefankandic @uros-db @mihailom-db @dbatomic |
mihailom-db
reviewed
May 16, 2024
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
Show resolved
Hide resolved
mihailom-db
reviewed
May 16, 2024
sql/core/src/test/scala/org/apache/spark/sql/CollationSQLExpressionsSuite.scala
Outdated
Show resolved
Hide resolved
mihailom-db
reviewed
May 16, 2024
sql/core/src/test/scala/org/apache/spark/sql/CollationSQLExpressionsSuite.scala
Outdated
Show resolved
Hide resolved
mihailom-db
approved these changes
May 16, 2024
|
@cloud-fan Please review :) |
uros-db
reviewed
May 17, 2024
sql/core/src/test/scala/org/apache/spark/sql/CollationSQLExpressionsSuite.scala
Outdated
Show resolved
Hide resolved
uros-db
reviewed
May 17, 2024
sql/core/src/test/scala/org/apache/spark/sql/CollationSQLExpressionsSuite.scala
Outdated
Show resolved
Hide resolved
uros-db
reviewed
May 17, 2024
sql/core/src/test/scala/org/apache/spark/sql/CollationSQLExpressionsSuite.scala
Outdated
Show resolved
Hide resolved
uros-db
reviewed
May 17, 2024
sql/core/src/test/scala/org/apache/spark/sql/CollationSQLExpressionsSuite.scala
Outdated
Show resolved
Hide resolved
uros-db
reviewed
May 17, 2024
sql/core/src/test/scala/org/apache/spark/sql/CollationSQLExpressionsSuite.scala
Outdated
Show resolved
Hide resolved
uros-db
reviewed
May 20, 2024
sql/core/src/test/scala/org/apache/spark/sql/CollationSQLExpressionsSuite.scala
Show resolved
Hide resolved
cloud-fan
approved these changes
May 22, 2024
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR introduces changes that will allow for collated strings to be passed to various datetime expressions or return value as collated string from those expressions.
Impacted datetime expressions:
Why are the changes needed?
This PR is part of ongoing effort to support collated strings on SparkSQL.
Does this PR introduce any user-facing change?
Yes, users will be able to use collated strings for datetime expressions.
How was this patch tested?
Added corresponding tests.
Was this patch authored or co-authored using generative AI tooling?
No.