[SPARK-48303][CORE] Reorganize LogKeys
#46612
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
SQL
ML
MLLIB
STRUCTURED STREAMING
KUBERNETES
YARN
CORE
R
DSTREAM
CONNECT
labels
panbingkun
changed the title
LogKeyLogKeys
gengliangwang
approved these changes
May 17, 2024
|
Thanks for the improvement! Merging to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to
reorganizeLogKeys, includes:remove some unused
LogLeysACTUAL_BROADCAST_OUTPUT_STATUS_SIZE
DEFAULT_COMPACTION_INTERVAL
DRIVER_LIBRARY_PATH_KEY
EXISTING_JARS
EXPECTED_ANSWER
FILTERS
HAS_R_PACKAGE
JAR_ENTRY
LOG_KEY_FILE
NUM_ADDED_MASTERS
NUM_ADDED_WORKERS
NUM_PARTITION_VALUES
OUTPUT_LINE
OUTPUT_LINE_NUMBER
PARTITIONS_SIZE
RULE_BATCH_NAME
SERIALIZE_OUTPUT_LENGTH
SHELL_COMMAND
STREAM_SOURCE
merge
PARAMETERintoPARAM(because some arefullspelled, and some areabbreviations, which are not unified)ESTIMATOR_PARAMETER_MAP -> ESTIMATOR_PARAM_MAP
FUNCTION_PARAMETER -> FUNCTION_PARAM
METHOD_PARAMETER_TYPES -> METHOD_PARAM_TYPES
merge
NUMBERintoNUM(abbreviations)MIN_VERSION_NUMBER -> MIN_VERSION_NUM
RULE_NUMBER_OF_RUNS -> NUM_RULE_OF_RUNS
VERSION_NUMBER -> VERSION_NUM
merge
TOTALintoNUMTOTAL_RECORDS_READ -> NUM_RECORDS_READ
TRAIN_WORD_COUNT -> NUM_TRAIN_WORD
NUMas prefixCHECKSUM_FILE_NUM -> NUM_CHECKSUM_FILE
DATA_FILE_NUM -> NUM_DATA_FILE
INDEX_FILE_NUM -> NUM_INDEX_FILE
COUNR -> NUM
EXECUTOR_DESIRED_COUNT -> NUM_EXECUTOR_DESIRED
EXECUTOR_LAUNCH_COUNT -> NUM_EXECUTOR_LAUNCH
EXECUTOR_TARGET_COUNT -> NUM_EXECUTOR_TARGET
KAFKA_PULLS_COUNT -> NUM_KAFKA_PULLS
KAFKA_RECORDS_PULLED_COUNT -> NUM_KAFKA_RECORDS_PULLED
MIN_FREQUENT_PATTERN_COUNT -> MIN_NUM_FREQUENT_PATTERN
POD_COUNT -> NUM_POD
POD_SHARED_SLOT_COUNT -> NUM_POD_SHARED_SLOT
POD_TARGET_COUNT -> NUM_POD_TARGET
RETRY_COUNT -> NUM_RETRY
fix some
typoMALFORMATTED_STIRNG -> MALFORMATTED_STRING
other
MAX_LOG_NUM_POLICY -> MAX_NUM_LOG_POLICY
WEIGHTED_NUM -> NUM_WEIGHTED_EXAMPLES
Changes in other code are additional changes caused by the above adjustments.
Why are the changes needed?
Let's make
LogKeyseasier to understand and more consistent.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.
Was this patch authored or co-authored using generative AI tooling?
No.