[SPARK-48300][SQL] Codegen Support for from_xml
#46609
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panbingkun
commented
May 16, 2024
| @@ -104,7 +103,7 @@ case class XmlToStructs( | |||
| if (mode != PermissiveMode && mode != FailFastMode) { | |||
| throw QueryCompilationErrors.parseModeUnsupportedError("from_xml", mode) | |||
| } | |||
| val (parserSchema, actualSchema) = nullableSchema match { | |||
There was a problem hiding this comment.
The variable actualSchema is not used anywhere
panbingkun
changed the title
from_xmlfrom_xml & remove some redundant codes
|
@panbingkun Thanks for submitting the PR. Can you please separate the |
|
|
After the PR above is merged, I will rebase the PR again just for |
panbingkun
changed the title
from_xml & remove some redundant codesfrom_xml
|
It has rebase the master. At present, this PR is only for |
yaooqinn
reviewed
May 21, 2024
sql/core/src/test/scala/org/apache/spark/sql/XmlFunctionsSuite.scala
Outdated
Show resolved
Hide resolved
yaooqinn
approved these changes
May 21, 2024
|
Merged to master. Thank you @panbingkun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The PR aims to add
Codegen Supportforfrom_xmlWhy are the changes needed?
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No.