-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-16763: Upgrade to scala 2.12.19 and scala 2.13.14 #15958
Conversation
@chia7712, This PR please take a look, Thank you. |
please file the build error |
@chia7712, Thanks for your review, Scala 2.3 build is passed in Jenkins |
build.gradle
Outdated
@@ -671,7 +671,8 @@ subprojects { | |||
"-Xlint:private-shadow", | |||
"-Xlint:stars-align", | |||
"-Xlint:type-parameter-shadow", | |||
"-Xlint:unused" | |||
"-Xlint:unused", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pardon me, why we need those changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I catch two main errors are class is depreate (1. ) and @nowarn
build error in previous build in Jenkins, but these classes or method are used by other classes. I consider that I should not migrate these methods or classes in this PR, thus I think that should closed these check when building scala version 2.3.
- ([Error] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-15958/core/src/main/scala/kafka/controller/KafkaController.scala:1202:18: method setOrCreatePartitionReassignment in class KafkaZkClient is deprecated)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue is caused by the magic NotNothing
. As we are in modern scala, could you try to remove it? I give a try on my local, and both compile and test work well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I will remove the "-Wconf:cat=unused-nowarn:s"
, and try to complie
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[2024-05-16T08:37:59.531Z] [Error] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-15958/core/src/main/scala/kafka/network/RequestChannel.scala:174:69: @nowarn annotation does not suppress any warnings
[2024-05-16T08:37:59.531Z] one error found
This error happened on Jenkins.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@m1a2st You have to remove the usage of NotNothing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
Scala has been releas new version, so upgrade scala version