-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: send async response #6534
base: 2.x
Are you sure you want to change the base?
optimize: send async response #6534
Conversation
Split RuntimeException from if-else to if statement using return early pattern for clarify.
Changed error message for clarity and leave channel name which is not available connected.
Changed if statement for checking whether message is instance of HeartbeatMessage or not to ternary conditional operator for clarity and immutable variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the review 🙇🏼 If there are any issues that i could help with just let me know anytime. Thanks 😄 |
Is there any issue to merge it?? |
我将在2.2版本上合并这个pr,当前2.1版本的里程碑已经完成接近于发版,暂时不进行合并pr |
I understand it. Thank you for the kind description. |
Ⅰ. Describe what this PR did
Optimize code and error message for clarity.
Ⅱ. Does this pull request fix one issue?